feat: added WalletConnect integration for improve tests speed#361
Open
feat: added WalletConnect integration for improve tests speed#361
Conversation
…etConnect handling
…etConnect handling
…n void and enhance transaction validation
…n void and enhance transaction validation
…tion cancellation
…tion cancellation
…ity and maintainability
Vorobeyko
changed the title
…esponse structure
itaven
reviewed
Mar 5, 2026
| @@ -7,16 +17,20 @@ export interface CommonWalletConfig { | |||
| WALLET_TYPE: WalletConnectType; | |||
| LATEST_STABLE_DOWNLOAD_LINK?: string; // Link to stable wallet extension version for test (optional) | |||
| EXTENSION_START_PATH: string; // Start path for wallet setup | |||
Contributor
There was a problem hiding this comment.
Is I'm correct that at this point of implementation WC direct connection EXTENSION_START_PATH also should be optional?
itaven
reviewed
Mar 5, 2026
| import type { WCSessionRequest } from '../components'; | ||
| import type { WCWallet } from '../wc.service'; | ||
|
|
||
| const isAddr = (v: unknown) => /^0x[a-fA-F0-9]{40}$/.test(String(v)); |
Contributor
There was a problem hiding this comment.
Better use
import { isAddress } from 'viem';
const isAddr = (v: unknown) => isAddress(String(v));
Also is it expected that address has unknown type?
itaven
reviewed
Mar 5, 2026
Comment on lines
+148
to
+155
| let proposal; | ||
| await test.step(`Pairing`, async () => { | ||
| [proposal] = await Promise.all([ | ||
| this.waitForProposalOnce(this.defaultTimeoutMs), | ||
| this.signClient.core.pairing.pair({ uri }), | ||
| ]); | ||
| }); | ||
| const { id, params } = proposal; |
Contributor
There was a problem hiding this comment.
Better to use if no cons
const proposal = await test.step('Pairing', async () => {
const [proposal] = await Promise.all([
this.waitForProposalOnce(this.defaultTimeoutMs),
this.signClient.core.pairing.pair({ uri }),
]);
return proposal;
});
const { id, params } = proposal;
itaven
reviewed
Mar 5, 2026
| async validateRequest( | ||
| req: WCSessionRequest, | ||
| ): Promise<WCSessionRequest | undefined> { | ||
| // @todo: think about it, i think its bullshit |
Contributor
There was a problem hiding this comment.
Could you explain root of the comment pls?
As i see it's used by
const currentPendingRequest = this.pendings[0];
->
if (currentPendingRequest) {
return this.validateRequest(currentPendingRequest);
}
->
// @todo: think about it, i think its bullshit
if (req.processed) {
If request is pending he can be in processed state?
itaven
reviewed
Mar 5, 2026
| async changeNetwork(networkName: string): Promise<void> { | ||
| await test.step(`Change network to ${networkName}`, async () => { | ||
| const chain = await this.networkSettings.changeNetwork(networkName); | ||
| this.rebuildViemClients(chain); |
itaven
reviewed
Mar 5, 2026
| } | ||
|
|
||
| private async rebuildViemClients(chain: Chain) { | ||
| test.step(`Rebuild Viem clients for chain ${chain.id}`, async () => { |
itaven
reviewed
Mar 5, 2026
| const net = | ||
| this.networkSettings.networksByChainId.get(chain.id) || | ||
| this.options.standConfig; | ||
| if (net?.rpcUrl) { |
Contributor
There was a problem hiding this comment.
Minor: net might be a bit ambiguous. Maybe networkConfig (or similar) would make the intent clearer.
itaven
reviewed
Mar 5, 2026
Comment on lines
+522
to
+523
| this.walletClient = null; | ||
| this.publicClient = null; |
Contributor
There was a problem hiding this comment.
Could you explain why do you need to set this.walletClient && this.publicClient to null? Where it should be inited? I see updateAllSessionsNamespaces after rebuildViemClients but for me it's confuised
jake4take
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.