Support angular expression in name and don't use global mouse events#14
Open
sjoerd222888 wants to merge 2 commits intolifelynl:masterfrom
Open
Support angular expression in name and don't use global mouse events#14sjoerd222888 wants to merge 2 commits intolifelynl:masterfrom
sjoerd222888 wants to merge 2 commits intolifelynl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have added an additional attribute ngCarouselExpression where you can give a real angular expression for the name.
Also we have change registration and unregistration of mouse events such that it does not affect other ui elements any more (because that was what is did),