Skip to content

Bug - $on('$destroy') #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
y-u-k-o wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bug - $on('$destroy') #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc673bf
Bug - $on('$destroy')
y-u-k-o Dec 20, 2016
26dbb32
Fixed global events
y-u-k-o Dec 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions angular-carousel.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ angular.module('angular-carousel', [])
// This directive makes an element with class 'ng-carousel' interactive
// using own UI logic and HammerJS
//
.directive('ngCarousel', ['Carousel', '$compile', '$document', '$timeout', function(Carousel, $compile, $document, $timeout) {
.directive('ngCarousel', ['Carousel', '$timeout', function(Carousel, $timeout) {
function isTouchDevice() {
return 'ontouchstart' in document.documentElement;
}
Expand Down Expand Up @@ -373,8 +373,8 @@ angular.module('angular-carousel', [])
// On release
var pressEvent = isTouchDevice() ? 'touchstart' : 'mousedown';
var releaseEvent = isTouchDevice() ? 'touchend' : 'mouseup';
$document.on(pressEvent, carouselPress);
$document.on(releaseEvent, carouselRelease);
element.on(pressEvent, carouselPress);
element.on(releaseEvent, carouselRelease);

//
element.on('mouseover', function() {
Expand All @@ -397,8 +397,8 @@ angular.module('angular-carousel', [])
scope.$on('$destroy', function() {
$timeout.cancel(refreshInteractionWithDomTimer);
element.off('mouseover mouseout');
$document.off(pressEvent);
$document.off(releaseEvent);
element.off(pressEvent, carouselPress);
element.off(releaseEvent, carouselRelease);
slideContainer.off('transitionend oTransitionEnd webkitTransitionEnd');
currentCarousel.onSlideChangeCallbacks = [];
Carousel.remove(name);
Expand Down