feat: allow encrypted secrets file syntax for checksum updates#82
Draft
CharlieDixon wants to merge 2 commits intolightdash:mainfrom
Draft
feat: allow encrypted secrets file syntax for checksum updates#82CharlieDixon wants to merge 2 commits intolightdash:mainfrom
CharlieDixon wants to merge 2 commits intolightdash:mainfrom
Conversation
Contributor
Author
|
Tested locally and is working as expected. To replicate, install the Helm chart to a cluster, passing in an additional secrets manifest which matches the wildcard syntax included in these changes. For example: helm install . -f /path/to/lightdash-secrets.yaml.encrypted --generate-name -n lightdash`.The Annotations: checksum/config: 3d43a82693a770f503798e4474b0025d484b6111738d56049a26318fff32ad46
checksum/secrets: 078bf8c86f91c1624faafbf55382d1a021f95fbd051616130bbc0644cf217db7Next, make an arbitrary change to the content of either the default helm upgrade [CHART] . -f /path/to/lightdash-secrets.encrypted -n lightdashN.B. The checksum generated for the ConfigMap remains the same but the secrets checksum has been updated in response to the changes which triggers a rolling restart of the deployment: Annotations: checksum/config: 3d43a82693a770f503798e4474b0025d484b6111738d56049a26318fff32ad46
checksum/secrets: 69b15bbe794142ea854bb7c04ae3f6ec71c263c038df5426c54caf076faea202 |
Contributor
Author
|
Set to draft pending resolution of conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a helper function to allow the
checksum/secretsannotation to be updated in response to changes in both the defaultsecret.yamlfile, as well as any files which match the wildcard patterns*secrets.yaml.encryptedor*secrets.enc.yaml, both of which are often used in conjunction with SOPS.Resolves #81