Fix bounding box computation for segmentations #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michal-lightly
commented
Jan 19, 2026
| def test_from_rle(self) -> None: | ||
| binary_mask_segmentation = BinaryMaskSegmentation.from_rle( | ||
| rle_row_wise=[1, 1, 4, 2, 1, 3, 2, 1, 5], | ||
| rle_row_wise=[6, 1, 4, 2, 1, 3, 2, 1], |
Contributor
Author
There was a problem hiding this comment.
Changed the test so that the XYXY bounding box format differs from the XYWH format.
Contributor
Author
|
/review |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
The bounding box was incorrectly computed. The xmax and ymax values are not the x- and y-coordinates of the extreme pixels, they are float positions of where they end.
I.e., the computed xmax and ymax values should be one larger.
How has it been tested?
Updated the test.