Fix dynamic batch sizes for onnx export #591
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guarin
requested changes
Feb 2, 2026
Comment on lines
+707
to
+708
| if dynamic_batch_size: | ||
| batch_size = 2 |
Contributor
There was a problem hiding this comment.
This will not work for most model as the code is not implemented for batch size > 1. Please check models and only enable for models that actually support it.
| batch_size: int = 1, | ||
| height: int | None = None, | ||
| width: int | None = None, | ||
| dynamic_batch_size: bool = True, |
Contributor
There was a problem hiding this comment.
Please update docstring in all models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed and why?
(Delete this: Please include a summary of the change and which issue is fixed. Please
also include relevant motivation and context. List any dependencies that are required
for this change.)
How has it been tested?
(Delete this: Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for your test
configuration.)
Did you update CHANGELOG.md?
Did you update the documentation?