[Grid] Move source into outgoing/incoming transaction #115
+189
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exs6350
changed the title
pengying
approved these changes
Dec 17, 2025
Contributor
pengying
left a comment
pengying
left a comment
There was a problem hiding this comment.
oneofs usually need a discriminator so long term this will likely need to change but for right now should be ok.
jklein24
approved these changes
Dec 17, 2025
exs6350
deleted the
12-17-move_source_into_outgoing_incoming_transaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves source out of the base transaction object and into the incoming/outgoing transaction. We still enforce it for outgoing transaction but not for a incoming transaction. The reason why we need to do this is because an incoming transaction like a funding event will not have a source