LCORE-1216: Bump up to llama-stack 0.4.3#52
LCORE-1216: Bump up to llama-stack 0.4.3#52are-ces wants to merge 2 commits intolightspeed-core:mainfrom
Conversation
b2b25c6 to
c84a80e
Compare
tisnik
left a comment
There was a problem hiding this comment.
I'd say LGTM on my side. But definitely need at least one more reviewer, especially from teams that managed to use provider(s).
There was a problem hiding this comment.
You are removing the inline::lightspeed_inline_agent we are using in Ansible Lightspeed chatbot, if this PR is merged this will break the chatbot functionality.
There was a problem hiding this comment.
inline::lightspeed_inline_agent still works, the logic has been moved from agent_instance.py to agents.py
lightspeed_stack_providers/providers/remote/agents/lightspeed_agent/lightspeed.py
Outdated
Show resolved
Hide resolved
218e6d4 to
3ad6905
Compare
|
@are-ces @ldjebran I could run the updated
The setup is somehow complicated because it's using a number of codes that are not merged to main yet. I will create a memo on my test setup. Note: My setup does not enable MCP server yet. After writing the memo, I plan to test this with MCP server enabled. |
3ad6905 to
f99d3c1
Compare
| "llama-stack==0.2.22", | ||
| "llama-stack-client==0.2.22", | ||
| "llama-stack==0.4.3", | ||
| "llama-stack-api==0.4.4", |
There was a problem hiding this comment.
why its not the same version 0.4.3 is this intentional ?
There was a problem hiding this comment.
I tried to use llama-stack-api 0.4.3 for ansible-chatbot-stack and it did not work. I think 0.4.3 is broken.
There was a problem hiding this comment.
Yes, because we updated LCORE to have the api package on 0.4.4 because of a CVE (v0.4.4 shouldn't have breaking changes)
|
@are-ces seems the file https://github.com/lightspeed-core/lightspeed-providers/blob/main/resources/external_providers/inline/agents/lightspeed_inline_agent.yaml needs to be updated to: config_class: lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent.config.LightspeedAgentsImplConfig
module: lightspeed_stack_providers.providers.inline.agents.lightspeed_inline_agent
api_dependencies: [ inference, safety, tool_runtime, tool_groups, conversations, prompts ]
optional_api_dependencies: [vector_io, files]The agent lightspeed_inline_agent is passing through the queries and overriding the temperature when configured , unfortunately I was not able to test mcp filtring as seems the lightspeed-stack has a regression as not passing mcp headers received from client by MCP-HEADERS header. There is a big work done her, @are-ces many thanks for your efforts, |
There was a problem hiding this comment.
@are-ces many thanks for the work the changes that I proposed in my last comment still valid, tested the mcp but seems the lightspeed_inline_agent is unfortunately not working as expected and breaking when enabling the mcp configuration, I see the mcp returning the list of tools, but the agent seems do not detect that tools and see only 2 instead of more than 300.
this will needs more investigations.
84d4bf7 to
622151e
Compare
|
Hey @ldjebran good catch! I have encountered the same problem, I was handling the tools in a wrong way; basically the MCP servers were not being expanded to their tools so we were counting the MCP servers and comparing them with min_tools. |
Description
This is a significant refactoring of all the modules, mostly because the Agents API has been deprecated in favor of the Responses API in llama-stack (already from 0.3.x).
This upgrade is needed to keep
lightspeed-providerson par with LCORENOTE:
run_moderationhas not been designed for redaction but to only block the request, thus lightspeed-redactions will block the message if an unauthorized string is detected, as opposed torun_shieldwhere it is possible to redact the original message.Changes:
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
I tested manually via curl requests the following:
run_shield(valid/invalid questions)run_moderationrun_shield(sensitive data redacted)run_moderation(message with sensitive data BLOCKED)