Added missing azure dependency#1153
Merged
are-ces merged 1 commit intolightspeed-core:mainfrom Feb 16, 2026
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 WalkthroughUpdated pyproject.toml: the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
⚔️ Resolve merge conflicts (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@test.containerfile`:
- Around line 20-21: Remove the ad-hoc `RUN uv add azure-identity` from the
container build because it mutates pyproject.toml/uv.lock at image build time
and breaks reproducibility; instead add `azure-identity` to the appropriate
dependency group in pyproject.toml (likely the llslibdev/dev group), regenerate
and commit the updated uv.lock, and rely on the existing `RUN uv sync --locked
--no-install-project --group llslibdev` to install it reproducibly (also prefer
using `uv run` for runtime commands and `uv sync --group dev --group llslibdev`
where relevant).
are-ces
force-pushed
the
add-azure-dep
branch
from
520d79e to
80b8b0e
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 192-193: Add a minimum version constraint to the azure-identity
dependency entries: replace the bare "azure-identity" tokens in both occurrences
(the one in the extras list and the one in the [project] dependencies section)
with a pinned minimum version such as "azure-identity>=1.25.2" so the project
consistently requires at least that stable release.
tisnik
requested changes
Feb 16, 2026
Contributor
tisnik
left a comment
tisnik
left a comment
There was a problem hiding this comment.
coderabbit is right, please put a minimum version there
are-ces
force-pushed
the
add-azure-dep
branch
from
80b8b0e to
49155bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding the missing Azure dependency from the llama-stack image
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit