Skip to content

Allow itemref targets with itemscope to be traversed #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hubgit wants to merge 1 commit into
base: 2.0.x
Choose a base branch
from
Open

Allow itemref targets with itemscope to be traversed #18

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/MicrodataPhpDOMElement.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public function properties() {
foreach ($this->itemRef() as $itemref) {
$children = $this->ownerDocument->xpath()->query('//*[@id="'.$itemref.'"]');
foreach($children as $child) {
$this->traverse($child, $toTraverse, $props, $this);
$this->traverse($child, $toTraverse, $props, $this, true);
}
}
while (count($toTraverse)) {
Expand Down Expand Up @@ -169,7 +169,7 @@ protected function tokenList($string) {
* See comment for MicrodataPhp:getObject() for an explanation of closure use
* in this library.
*/
protected function traverse($node, &$toTraverse, &$props, $root) {
protected function traverse($node, &$toTraverse, &$props, $root, $itemref = false) {
foreach ($toTraverse as $i => $elem) {
if ($elem->isSameNode($node)){
unset($toTraverse[$i]);
Expand All @@ -181,7 +181,7 @@ protected function traverse($node, &$toTraverse, &$props, $root) {
//@todo Add support for property name filtering.
$props[] = $node;
}
if ($node->itemScope()) {
if (!$itemref && $node->itemScope()) {
return;
}
}
Expand Down