Add methods for storing vectors back to memory #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
(Will add changeling entry upon approval.) |
LaurenzV
commented
Jan 3, 2026
Comment on lines
+170
to
+173
| /// Store a SIMD vector into a slice. | ||
| /// | ||
| /// The slice must be the proper width. | ||
| fn store_slice(&self, slice: &mut [Self::Element]); |
Collaborator
Author
There was a problem hiding this comment.
Maybe we should rename to store_into_slice?
Contributor
There was a problem hiding this comment.
I think store_slice is fine.
LaurenzV
changed the title
valadaptive
approved these changes
Jan 14, 2026
Contributor
valadaptive
left a comment
valadaptive
left a comment
There was a problem hiding this comment.
This looks good! Just a few minor code style nits.
| /// `[f32; 4]` for `f32x4<S>`) or a reference to it. | ||
| AsArray { kind: RefKind }, | ||
| /// Takes a vector and a mutable reference to an array, and stores the vector elements into the array. | ||
| ToArray, |
Contributor
There was a problem hiding this comment.
Maybe this should be renamed StoreArray?
| } else { | ||
| let blocks = (0..block_count).map(|n| { | ||
| let offset = n * num_scalars_per_block; | ||
| let block_idx = proc_macro2::Literal::usize_unsuffixed(n); |
Contributor
There was a problem hiding this comment.
Is there a reason to use usize_unsuffixed here specifically? It definitely results in nicer generated code but we don't seem to use it in many other places.
Collaborator
Author
There was a problem hiding this comment.
It does seem to be used in various places, no? 🤔
Comment on lines
+170
to
+173
| /// Store a SIMD vector into a slice. | ||
| /// | ||
| /// The slice must be the proper width. | ||
| fn store_slice(&self, slice: &mut [Self::Element]); |
Contributor
There was a problem hiding this comment.
I think store_slice is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, by having this, we don't have to store them back using
copy_from_slice(which may or may not optimize into vector store instructions) but can use methods that use the corresponding intrinsics under the hood.