-
Notifications
You must be signed in to change notification settings - Fork 663
fixed : expose response_mime_type for Google Gemini provider #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed : expose response_mime_type for Google Gemini provider #1265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Just adding response_mime_type in provider setting wont work. Can you try logging actual api call in generateText function to verify. |
maxprilutskiy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the comment and cleanup the pr from unnecessary change. thank you!
| { | ||
| "compilerOptions": { | ||
| "baseUrl": ".", | ||
| "paths": { | ||
| "@lingo.dev/_sdk": ["packages/sdk/src"], | ||
| "@lingo.dev/_sdk/*": ["packages/sdk/src/*"], | ||
| "@lingo.dev/_react": ["packages/react/src"], | ||
| "@lingo.dev/_react/*": ["packages/react/src/*"], | ||
| "@lingo.dev/_react/client": ["packages/react/src/client"], | ||
| "@lingo.dev/_react/rsc": ["packages/react/src/rsc"], | ||
| "@lingo.dev/_react/react-router": ["packages/react/src/react-router"], | ||
| "@lingo.dev/_compiler": ["packages/compiler/src"], | ||
| "@lingo.dev/_compiler/*": ["packages/compiler/src/*"], | ||
| "@lingo.dev/_locales": ["packages/locales/src"], | ||
| "@lingo.dev/_locales/*": ["packages/locales/src/*"], | ||
| "@lingo.dev/_spec": ["packages/spec/src"], | ||
| "@lingo.dev/_spec/*": ["packages/spec/src/*"] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed? Must be removed if it is irrelevant.
esolved the issue where Google Gemini models (used via Lingo.dev)