Add AppendBinary to append avro data without getting binary from native#251
Open
CharmCcc wants to merge 1 commit intolinkedin:masterfrom
Open
Add AppendBinary to append avro data without getting binary from native#251CharmCcc wants to merge 1 commit intolinkedin:masterfrom
CharmCcc wants to merge 1 commit intolinkedin:masterfrom
Conversation
AppendBinary appends one or more avro data from pulsar/kafka to an OCF file in a block.
CharmCcc
changed the title
Author
|
Now I have a lot of avro data from pulsar/kafka, I want to use ocfwrite to append them to an OCF file. |
Contributor
|
Hi, and thanks! I don't see anything pulsar/kafka specific in the PR. It looks like a general utility for the OCF functionality and seems desirable. Is that right? Would you be willing to provide some unit tests? I'd feel more confident about a merge if we had some passing tests in place for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppendBinary appends one or more avro data from pulsar/kafka to an OCF file in a block.