Fix panic in buildCodecForTypeDescribedByString#289
Open
liron-l wants to merge 1 commit intolinkedin:masterfrom
Open
Fix panic in buildCodecForTypeDescribedByString#289liron-l wants to merge 1 commit intolinkedin:masterfrom
buildCodecForTypeDescribedByString#289liron-l wants to merge 1 commit intolinkedin:masterfrom
Conversation
scale attribute is optional in schema:
```
The following attributes are supported:
• scale, a JSON integer representing the scale (optional). If not specified the scale is 0.
• precision, a JSON integer representing the (maximum) precision of decimals stored
in this type (required)
```
If it's missing from format, code will panic on
```
panic: interface conversion: interface {} is nil, not float64
```
Ensure code robustness and verify both values are cast-able to float64.
Author
|
@mittal-aashay can you please review? |
Author
|
@mittal-aashay who is maintaining this library? |
rockwotj
reviewed
Jan 10, 2025
| // using the cached codec in favor of creating a new codec. | ||
| if searchType == "bytes.decimal" { | ||
| precision, ok1 := schemaMap["precision"].(float64) | ||
| scale, ok2 := schemaMap["scale"].(float64) |
Collaborator
There was a problem hiding this comment.
Shouldn't this default to 0 instead, otherwise we never get a cache hit for something without an explicit scale?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scale attribute is optional in schema:
If it's missing from format, code will panic on
Ensure code robustness and verify both values are cast-able to float64.