Fix fixed type slices using same underlying array#305
Open
Nepomuk5665 wants to merge 1 commit intolinkedin:masterfrom
Open
Fix fixed type slices using same underlying array#305Nepomuk5665 wants to merge 1 commit intolinkedin:masterfrom
Nepomuk5665 wants to merge 1 commit intolinkedin:masterfrom
Conversation
When decoding binary fixed types, the returned byte slice was a subslice of the input buffer. This meant all decoded fixed values shared the same underlying array, causing unexpected behavior when appending to these slices - modifications could affect other decoded values or the original input buffer. This is the same issue as linkedin#269 but for the fixed type. PR linkedin#270 fixes the bytes type but does not address the fixed type which has the same problem. The fix allocates a new slice and copies the data, ensuring each decoded fixed value has its own independent backing array.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug where decoded fixed type values share the same underlying array as the input buffer and other decoded values, causing unexpected behavior when appending to these slices.
Problem
This is the same issue as #269 but for the
fixedtype. PR #270 fixes thebytestype but does not address thefixedtype which has the identical problem.When decoding binary fixed types in
makeFixedCodec, thenativeFromBinaryfunction returnsbuf[:size]directly - a subslice of the input buffer. This means:Solution
Allocate a new slice and copy the data instead of returning a subslice:
This ensures each decoded fixed value has its own independent backing array.
Testing
Added
TestFixedSlicesUseIndependentBackingArrayswhich:All existing tests continue to pass.
Related