feat(app/inbound): introduce response duration metrics #4420
+128
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
requested review from
unleashed and
zaharidichev
and removed request for
a team
unleashed
approved these changes
Feb 10, 2026
Member
unleashed
left a comment
unleashed
left a comment
There was a problem hiding this comment.
Looks good, just a small nit about adding a comment with the rationale for choosing the bucket granularities just like you do for the PR.
| } | ||
| } | ||
|
|
||
| const RESPONSE_BUCKETS: &'static [f64] = &[0.05, 0.5, 1.0, 10.0]; |
Member
There was a problem hiding this comment.
You already justify why these buckets are chosen in the PR text, but I think it would help to add a comment here with the rationale.
this commit introduces a new middleware layer to the inbound proxy. this instruments inbound traffic with Prometheus telemetry that records response body latency, and emits a histogram of response body durations. the buckets are chosen to mimic the request and response buckets emitted by the outbound proxy, with their granularity flipped. in other words, the inbound proxy is more interested in fine-grained request body metrics than response body metrics, while the outbound proxy is more interested in fine-grained response body metrics than request body metrics. * #4418 * #4419 Signed-off-by: katelyn martin <kate@buoyant.io>
cratelyn
force-pushed
the
kate/app-inbound.duration-metrics
branch
from
6707ef3 to
7684330
Compare
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduces a new middleware layer to the inbound proxy.
this instruments inbound traffic with Prometheus telemetry that records
response body latency, and emits a histogram of response body durations.
the buckets are chosen to mimic the request and response buckets emitted
by the outbound proxy, with their granularity flipped. in other words,
the inbound proxy is more interested in fine-grained request body
metrics than response body metrics, while the outbound proxy is more
interested in fine-grained response body metrics than request body
metrics.