feat: add ability to create new collections directly from popup#141
Open
danilosekulovikj wants to merge 1 commit intolinkwarden:mainfrom
Open
feat: add ability to create new collections directly from popup#141danilosekulovikj wants to merge 1 commit intolinkwarden:mainfrom
danilosekulovikj wants to merge 1 commit intolinkwarden:mainfrom
Conversation
Allows users to create new collections directly from the extension popup and options page, significantly reducing friction when saving links. Features and improvements: - Lazily creates the collection upon saving the bookmark to prevent orphaned empty collections if the user cancels. - Implements a pinned footer inside the collection dropdown for creating a new collection based on the search input. - Displays a clear, centered 'Create' button in the empty state when no existing collections match the search query. - Uses trimmed, case-insensitive checks to prevent creating duplicate collections or whitespace-only names. - Adds specific error handling to distinguish between link save failures and collection creation failures. - Fixes dark mode styling for the dropdown overlay. - Refactors the dropdown collection list to eliminate code duplication across rendering paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allows users to create new collections directly from the extension popup and options page, significantly reducing friction when saving links.
Features and improvements
cmdkfilter function to.trim()search input, ensuring that typing trailing spaces (e.g.,"Test ") doesn't incorrectly hide existing collections.bg-neutral-900) for the dropdown overlay and fixed auseEffectlinter warning inBookmarkForm.tsx.How to Test