new: Support deleting IP address #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yec-akamai
requested review from
ezilber-akamai and
jriddle-linode
and removed request for
a team
ezilber-akamai
approved these changes
Jan 21, 2025
Contributor
ezilber-akamai
left a comment
ezilber-akamai
left a comment
There was a problem hiding this comment.
LGTM and tests are passing localy. Nice work!
lgarber-akamai
approved these changes
Jan 22, 2025
Contributor
lgarber-akamai
left a comment
lgarber-akamai
left a comment
There was a problem hiding this comment.
Looks great, nice work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Allow user to use
ip.delete()when they want to delete a public or private IPv4 address associated with a Linode. This will fail if it is the Linode's last remaining public IPv4 address, or if the address has a 1:1 NAT with an active VPC Subnet address.It overrides the delete() function from base to adapt the correct endpoint for IPAddress.
✔️ How to Test