Drop the LKE ACL addresses field when its value is null

[lgarber-akamai]

📝 Description

This pull request updates the LKE cluster create and control plane ACL update methods to drop the addresses field if its value is null. This is necessary because an explicit null value is rejected by the API.

✔️ How to Test

The following test steps assume you have pulled down this PR locally.

Unit Testing

make test-unit

Integration Testing

make test-int

Manual Testing

1. In a linode_api4-python sandbox environment (e.g. dx-devenv), run the following:

import os

from linode_api4 import LinodeClient


def main():
    client = LinodeClient(os.getenv("LINODE_TOKEN"))

    cluster = client.lke.cluster_create(
        region="us-mia",
        label="apl-test",
        kube_version="1.32",
        node_pools=[client.lke.node_pool("g6-standard-1", 3)],
        control_plane={
            "acl": {
                "enabled": True,
                "addresses": None,
            }
        },
    )

    print("Cluster:", cluster)


if __name__ == "__main__":
    main()

2. Ensure the cluster is created successfully.

[lgarber-akamai]

drop_null_keys(...) needed to be moved outside of the _flatten_request_body_recursive(...) call because it doesn't have handling for JSONObjects.

[jriddle-linode]

Working locally LGTM

[ezilber-akamai]

I'm consistently getting some test failures. Could be related to the ACL API change that got released yesterday, but I'm not sure.

FAILED test/integration/models/lke/test_lke.py::test_lke_cluster_acl - AssertionError: assert [] == ['10.0.0.2/32']
FAILED test/integration/models/lke/test_lke.py::test_lke_cluster_update_acl_null_addresses - AssertionError: assert [] == ['10.0.0.1/32']
FAILED test/integration/models/lke/test_lke.py::test_lke_cluster_disable_acl - assert False

[lgarber-akamai]

I'm consistently getting some test failures. Could be related to the ACL API change that got released yesterday, but I'm not sure.

FAILED test/integration/models/lke/test_lke.py::test_lke_cluster_acl - AssertionError: assert [] == ['10.0.0.2/32']
FAILED test/integration/models/lke/test_lke.py::test_lke_cluster_update_acl_null_addresses - AssertionError: assert [] == ['10.0.0.1/32']
FAILED test/integration/models/lke/test_lke.py::test_lke_cluster_disable_acl - assert False

Looks like it was indeed related to the API Change, thanks for the heads up!

[ezilber-akamai]

Passing locally!