Skip to content

Conversation

@richm
Copy link
Contributor

@richm richm commented Nov 14, 2025

community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582

By default, installation will get the latest 11.x version. The lower bound
6.6.0 is an older version, but I don't want to restrict the ability of a user
of a particular role to use an old version, rather than forcing them to use
11.x or later. Some roles like rhc explicitly require 6.6.0 or later - I
think this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own community_general_version in the role's
host_vars file in .github.

Standardize file format across all roles for consistency and ease of updating

This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Restrict community.general to compatible versions by default and standardize requirements file management

Bug Fixes:

  • Prevent installation of community.general v12 which drops Python 2.7/3.6 support

Enhancements:

  • Default to latest 11.x (with a lower bound of 6.6.0) for community.general and allow per-role overrides via host_vars
  • Standardize collection-requirements.yml format across roles with a managed "DO NOT EDIT" header, removing SPDX boilerplate

community.general version 12 has dropped support for py27 and py36 - ensure that
the roles do not install/use this version - see
ansible-collections/community.general#582

By default, installation will get the latest 11.x version. The lower bound
`6.6.0` is an older version, but I don't want to restrict the ability of a user
of a particular role to use an old version, rather than forcing them to use
`11.x` or later. Some roles like `rhc` explicitly require `6.6.0` or later - I
think this is a reasonable lower bound for all roles.If a role needs a different
version, the role can define its own `community_general_version` in the role's
`host_vars` file in .github.

Standardize file format across all roles for consistency and ease of updating

This update may remove the SPDX license information from the file - this is ok -
the role/project already has a license, this file is trivial, and many
requirements files do not have the license header anyway.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner November 14, 2025 20:10
@richm richm self-assigned this Nov 14, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Nov 14, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enforces Python compatibility by pinning the community.general collection to versions >=6.6.0,<12.0.0 across all roles, introduces a standardized header for managed requirement files, and retains per-role override support.

Entity relationship diagram for updated collection requirements management

erDiagram
    ROLE {
        string name
        string community_general_version
    }
    COLLECTION_REQUIREMENTS {
        string managed_by
        string version_constraint
    }
    ROLE ||--|{ COLLECTION_REQUIREMENTS : "uses"
Loading

File-Level Changes

Change Details Files
Pin community.general to supported versions
  • Added ">=6.6.0,<12.0.0" specifier to collection-requirements.yml entries
  • Set default lower bound at 6.6.0 while avoiding forcing all users to latest 11.x
  • Documented override via community_general_version in host_vars
roles/*/meta/collection-requirements.yml
.github/host_vars/*.yml
Standardize managed requirements file format
  • Inserted uniform "# DO NOT EDIT THIS FILE - managed by linux-system-roles/.github" header
  • Removed SPDX license comments from collection-requirements.yml
  • Aligned YAML structure and indentation consistently across roles
roles/*/meta/collection-requirements.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm merged commit 29bc834 into main Nov 15, 2025
37 checks passed
@richm richm deleted the community-general-11.x branch November 15, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants