add target specific variables #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add assignment expression list to the Rule class - rearrange adding Rule to RuleDB in order to handle the subtleties of adding assignments to a rule vs overriding a rule (needs more tests) - fix a few places where .makefile() returned bad recipes (and fix the subsequent failing tests)
In order to support rule-specific variables, let's add a 'layer' scheme to the symbol table. A "layer" is another dict with key:value as name:Entry. The layers are stored in an array, with [0] as the topmost layer. Variable lookups search starting at [0]. Variables only added to layer [0]. Removed the old push/pop variable code. Need to add test code.
- add a layer for recipe execution - fix bugs found in new tests - fix export of an undefined variable
GNU Make 4.1 (Used in Ubuntu systems in Github CI) doesn't export variables to $(shell) calls. The feature was added in GNU Make 4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Target Specific Assignment support