Dpoole/fix stdout stderr shellflags #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- subprocess calls should always send stderr outwards (no capture) - add option to capture or not capture stdout so $(shell) will be captured but recipes will go outwards (no capture) - set stdout to flush on every print() to match GNU Make which uses setbuf() (which isn't available to python) because otherwise stdout can race between pymake process and subprocess stdout - start tests on $(SHELLFLAGS) which is what led to finding these problems with stdout
- remove stderr entirely from ShellReturn - clean up calling subprocess.run() in shell.execute()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix stdout vs stderr handling; fix .SHELLFLAGS