Skip to content

csd-power-manager.c: Sent property updates when the percentage changes, not just an icon.#438

Merged
mtwebster merged 1 commit intomasterfrom
power-percent-updates
Jan 17, 2026
Merged

csd-power-manager.c: Sent property updates when the percentage changes, not just an icon.#438
mtwebster merged 1 commit intomasterfrom
power-percent-updates

Conversation

@mtwebster
Copy link
Member

@mtwebster mtwebster commented Jan 17, 2026

Commit c2c7609 removed the Tooltip property from csd-power. We
weren't making use of that property anywhere in Cinnamon, but it
was doing the work of triggering updates there whenever the battery
percentage changed, keeping the applet up-to-date in between actual
icon changes.

There's no point in reverting everything - most is string handling
that we still don't need. Instead, implement a simple percentage
monitor and dbus Property to trigger updates for clients.

Fixes linuxmint/cinnamon#13324.

@mtwebster mtwebster force-pushed the power-percent-updates branch from a5f8f49 to 99dd804 Compare January 17, 2026 17:20
changes, not just an icon.

Commit c2c7609 removed the Tooltip property from csd-power. We
weren't making use of that property anywhere in Cinnamon, but it
was doing the work of triggering updates there whenever the battery
percentage changed, keeping the applet up-to-date in between actual
icon changes.

There's no point in reverting everything - most is string handling
that we still don't need. Instead, implement a simple percentage
monitor and dbus Property to trigger updates for clients.

Fixes linuxmint/cinnamon#13324.
@mtwebster mtwebster force-pushed the power-percent-updates branch from 99dd804 to 43745ac Compare January 17, 2026 17:25
@mtwebster
Copy link
Member Author

/generate-test-packages

@github-actions
Copy link

Test packages generated successfully!

Download from the workflow run (available for 7 days).

@mtwebster mtwebster merged commit 8165fc6 into master Jan 17, 2026
3 checks passed
@okaestne
Copy link
Contributor

Sorry for causing this regression. I think we should try to let the applet fetch the data from upower directly.

@mtwebster
Copy link
Member Author

It's ok, if we're not breaking things occasionally, we're not making enough of an effort :)

cinnamon-settings' cs_power.py also accesses this stuff also, but that's definitely something to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Power Manager applet sometimes not updating battery percentage

2 participants