add rocksdb_sstfilewriter_create_with_column_family_handle#176
Open
ltagliamonte-dd wants to merge 2 commits intolinxGnu:masterfrom
Open
add rocksdb_sstfilewriter_create_with_column_family_handle#176ltagliamonte-dd wants to merge 2 commits intolinxGnu:masterfrom
ltagliamonte-dd wants to merge 2 commits intolinxGnu:masterfrom
Conversation
linxGnu
requested changes
Apr 5, 2025
| const rocksdb_envoptions_t* env, const rocksdb_options_t* io_options, | ||
| const rocksdb_comparator_t* comparator); | ||
| extern ROCKSDB_LIBRARY_API rocksdb_sstfilewriter_t* | ||
| rocksdb_sstfilewriter_create_with_column_family_handle( |
Owner
There was a problem hiding this comment.
Hi @ltagliamonte-dd
I think you should drive your PR to upstream https://github.com/facebook/rocksdb/blob/v10.0.1/include/rocksdb/c.h instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow to create a sstfilewriter with CF handler to pass CF information
@linxGnu please take a look