Handle the crash on initializing root view controller.#5
Open
sheepy1 wants to merge 1 commit intoliuslevis:masterfrom
Open
Handle the crash on initializing root view controller.#5sheepy1 wants to merge 1 commit intoliuslevis:masterfrom
sheepy1 wants to merge 1 commit intoliuslevis:masterfrom
Conversation
| self.window.rootViewController = [[UIViewController alloc] init]; | ||
| } else { | ||
| // 使用 storyboard 时，需要把 rootController 存下来，待修复完成后，重新设置 self.window.rootViewController | ||
| self.originalRootViewController = self.window.rootViewController; |
There was a problem hiding this comment.
这样写有一个前提，rootViewController在初始化的时候不会crash
Author
There was a problem hiding this comment.
你是说在 rootViewController 的 initWithCoder 里有崩溃的逻辑么，这种情况我暂时没找到解决的办法，因为这种情况在 didFinishLaunching 调用前就已经 crash 了……用这个库的思路（Method Swizzling 动态替换 didFinishLaunching 方法）解决不了这种问题。不过我觉得这种情况应该也很少发生，使用 sb 的话很少会去重写 rootViewController 的 initWithCoder 方法吧。可以在 README 中向使用者说明一下这种情况。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.