fix(resizeImageToCover): switch to canvas to support Firefox#126
Open
FloChehab wants to merge 1 commit intolivekit:mainfrom
Open
fix(resizeImageToCover): switch to canvas to support Firefox#126FloChehab wants to merge 1 commit intolivekit:mainfrom
FloChehab wants to merge 1 commit intolivekit:mainfrom
Conversation
Previous implementation was producing distorted images on Firefox. Switching to canvas based API which has better broader support.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a quick fix regarding the resize / crop logic for backgrounds.
The previous implementation was producing distorted / not-cropped images on Firefox (but working on Chrome), apparently the
createImageBitmapdoesn't behave in the same exact way between Browser.Switching to canvas based API which has better broader support.
I have tested my fix on both Chrome & Firefox.