Fix issue with POST parameters being separated by "&" instead of "&"#7
Open
tgmayfield wants to merge 1 commit intollagerlof:masterfrom
Open
Fix issue with POST parameters being separated by "&" instead of "&"#7tgmayfield wants to merge 1 commit intollagerlof:masterfrom
tgmayfield wants to merge 1 commit intollagerlof:masterfrom
Conversation
Owner
|
@tgmayfield, thank you for taking the time to debug a potential problem with the library. I find it strange because I use it to make GET and POST requests to more than one Moodle webservices in production systems and have never had an issue - works on my machineS ;-) This makes me think that the error you're encountering is an exception. Based on your discovery, I'll try to reproduce this problem to determine if the solution you found works for all cases or if the root of the problem is something deeper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I battled for way too long to get the Moodle enrol_manual_enrol_users service to work. I finally got it working correctly with PHP curl functions, and then had to compare why that one worked and this code didn't. It came down to ampersands being in the POST data.
CURL post data:
MoodleRest post data: