Conversation
Codecov Report
@@ Coverage Diff @@
## releases/v2.1.1 #213 +/- ##
================================================
Coverage 75.67% 75.67%
================================================
Files 123 123
Lines 8065 8065
================================================
Hits 6103 6103
Misses 1962 1962Continue to review full report at Codecov.
|
| option(WITH_SOS "Enable SOSFlow data management" FALSE) | ||
| option(WITH_TAU "Enable TAU service (TAU Performance System)" FALSE) | ||
| option(WITH_VTUNE "Enable Intel(R) VTune(tm) annotation bindings" FALSE) | ||
| option(WITH_GEOPM "Enable GEOPM service" TRUE) |
| include(FindGeopm) | ||
| if(GEOPM_FOUND) | ||
| message(STATUS "Found geopm.h in " ${GEOPM_INCLUDE_DIR}) | ||
| message(STATUS "Found libgeopm.so in " ${GEOPM_LIBRARY}) |
There was a problem hiding this comment.
Replace with GEOPM (check the list of messages at the end of CMakeLists.txt
There was a problem hiding this comment.
Check line number CMakeLists.txt: 393
| # GEOPM_LIBRARY - Name of GEOPM library file | ||
| # GEOPM_FOUND - True if GEOPM was found | ||
|
|
||
| #set(GEOPM_INSTALL "" CACHE PATH "GEOPM install directory") |
| ) | ||
|
|
||
| list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DDEBUGLEVEL=2") |
There was a problem hiding this comment.
Remove (do not usually change CFLAGS
| Geopm.cpp | ||
| ) | ||
|
|
||
| list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2") |
|
|
||
| list(APPEND CALIPER_EXTERNAL_LIBS " -DDEBUGLEVEL=2") | ||
| set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DDEBUGLEVEL=2") | ||
| set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DDEBUGLEVEL=2") |
| chn->events().pre_begin_evt.connect(::geopm_begin_region); | ||
| chn->events().pre_end_evt.connect(::geopm_end_region); |
There was a problem hiding this comment.
Migrate to annotation binding class (example NVPROF service code).
| } | ||
| } | ||
|
|
||
| if(attr.name() == "annotation") { |
There was a problem hiding this comment.
Note: need to separate outermost annotation from individual kernel annotations.
| /* Start of a loop in the application, initialize loop count | ||
| * to update fractional progress later | ||
| */ | ||
| if(regionname.to_string() == "mainloop") { |
There was a problem hiding this comment.
Make the outer loop name configuration.
amarathe84
left a comment
amarathe84
left a comment
There was a problem hiding this comment.
- Measure overhead of Caliper service + GEOPM.
| */ | ||
|
|
||
| /* check if the attribute type is annotation, loop or function, and create a region ID. */ | ||
| if(attr.name() == "annotation") { |
There was a problem hiding this comment.
Look up built-in attributes by ID instead of strings.
|
|
||
| void geopm_begin_region(Caliper* c, Channel* chn, const Attribute& attr, const Variant& regionname) { | ||
| int err; | ||
| std::string sRegionName(regionname.to_string()); |
There was a problem hiding this comment.
Find out the scope of annotation attribute (process or thread).
| if(geopm_phase_map.end() == geopm_phase_map.find(sRegionName)) { | ||
| uint64_t phase_rid = GEOPM_NULL_VAL; | ||
| geopm_prof_region(sRegionName.c_str(), GEOPM_REGION_HINT_COMPUTE, &phase_rid); | ||
| geopm_phase_map.insert(std::pair<std::string, uint64_t>(sRegionName, phase_rid)); |
There was a problem hiding this comment.
Figure out if we can avoid string copy.
| * to update fractional progress later | ||
| */ | ||
| if(regionname.to_string() == "mainloop") { | ||
| /* Nothing to do at the start of the mainloop */ |
There was a problem hiding this comment.
Refactor this part of the code
| } else { | ||
| /* This is neither the main loop nor an OpenMP loop, | ||
| * therefore, mark process-level progress */ | ||
| geopm_prof_progress(geopm_phase_map[sRegionName], |
There was a problem hiding this comment.
Make sure there is no division by zero (exists check)
2 participants
This PR is for the GEOPM service that we've developed for Caliper. The GEOPM service for Caliper enables transparently linking the GEOPM runtime system (https://github.com/geopm/geopm) for power management with the application through the Caliper markup API. The service captures region attribute updates and maps them to GEOPM application markups. The service handles updates to both OMP and non-OMP regions. The GEOPM markups are listed on this page: https://geopm.github.io/man/geopm_prof_c.3.html. The mapping between Caliper markups and GEOPM markups is listed in src/services/geopm/doc/GEOPM-mapping.pdf.