feat: extend PDPR1H1HAW100_FW539187 mapping with 22 new entities#24
Merged
lmaertin merged 1 commit intolmaertin:mainfrom Mar 13, 2026
Merged
Conversation
Add 22 new entities discovered via live device analysis: - 11 binary_sensors: OFA2 alarms, temperature/concentration alarms, system standby - 6 sensors with conversions: circulation pump status, peristaltic CL dosing, device config, temperature unit, power-on/flow delay status - 5 numbers: dosing off-timers (pH/ORP/CL), power-on delay timer, flow delay timer Total mapped entities: 32 -> 54 Skipped: alarm-page duplicates, read-only timer displays, opaque device status, redundant flowrate unit display Add 8 tests for the extended mapping covering entity counts, alarm binary sensors, sensor conversions, and number entities.
Owner
|
Thanks, this is a very advanced Pooldose variant, nice to see all those additional values. Let's check what we shall take to home assistant as well for monitoring or automations. I will release the new lib today/tmrw and create a PR to bump to it in HA core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the mapping for model PDPR1H1HAW100 (FW539187) from 32 to 54 entities based on live device analysis.
New entities (22)
Binary sensors (11)
alarm_ofa2_ph/alarm_ofa2_orp/alarm_ofa2_cl— secondary overfeed alarmsalarm_water_too_cold/alarm_water_too_hot— water temperature alarmsalarm_ph_too_low/alarm_ph_too_high— pH concentration alarmsalarm_cl_too_low_orp/alarm_cl_too_high_orp/alarm_cl_too_high— chlorine alarmsalarm_system_standby— system standby alarmSensors with conversions (6)
circulation_pump_status— disabled/enabledperistaltic_cl_dosing— addscycleas 5th option (off/proportional/on_off/timed/cycle)device_config— ph_orp / ph_orp_chlorinetemperature_unit— celsius/fahrenheitpower_on_delay_status— disabled/enabledflow_delay_status— disabled/enabledNumbers (5)
time_off_ph_dosing/time_off_orp_dosing/time_off_cl_dosing— dosing off-timerspower_on_delay_timer/flow_delay_timer— delay timersDeliberately skipped
Note
A follow-up PR on the Home Assistant core integration will be needed to add the corresponding
EntityDescriptionentries for the new entities to appear in HA.All 130 tests pass.