Skip to content

Convert enabled/disabled sensors to binary_sensor type#28

Closed
ronaldvdmeer wants to merge 0 commit intolmaertin:mainfrom
ronaldvdmeer:fix/enable-disable-to-binary-sensor
Closed

Convert enabled/disabled sensors to binary_sensor type#28
ronaldvdmeer wants to merge 0 commit intolmaertin:mainfrom
ronaldvdmeer:fix/enable-disable-to-binary-sensor

Conversation

@ronaldvdmeer
Copy link
Contributor

Convert circulation_pump_status, power_on_delay_status, and flow_delay_status from sensor type with string conversion (disabled/enabled) to binary_sensor type with boolean conversion (false/true).

This aligns with Home Assistant's entity model where on/off states should be represented as binary sensors rather than enum sensors.

Changes

  • model_PDPR1H1HAW100_FW539187.json: Changed type from sensor to binary_sensor and conversion values from "disabled"/"enabled" to false/true for:
    • circulation_pump_status
    • power_on_delay_status
    • flow_delay_status
  • test_mapping_info.py: Updated entity type counts (sensor 22→19, binary_sensor 20→23) and moved the 3 entities from sensor to binary_sensor test assertions

CLI output for cross-check

pump_alarm: False
ph_level_alarm: False
orp_level_alarm: False
flow_rate_alarm: False
relay_alarm: True
relay_aux1: False
relay_aux2: False
alarm_ofa_ph: False
alarm_ofa_orp: False
alarm_ofa2_ph: False
alarm_ofa2_orp: False
alarm_ofa2_cl: False
alarm_water_too_cold: True
alarm_water_too_hot: False
alarm_ph_too_low: False
alarm_ph_too_high: False
alarm_cl_too_low_orp: False
alarm_cl_too_high_orp: False
alarm_cl_too_high: False
alarm_system_standby: False
circulation_pump_status: False <-- was sensor with 'disabled'
power_on_delay_status: False <-- was sensor with 'disabled'
flow_delay_status: False <-- was sensor with 'disabled'

@ronaldvdmeer
Copy link
Contributor Author

#27 failed on the tests.. This is the new PR with the fix in test script

@ronaldvdmeer ronaldvdmeer force-pushed the fix/enable-disable-to-binary-sensor branch from d2e844f to abfc5e0 Compare March 15, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant