Convert enabled/disabled sensors to binary_sensor type#28
Closed
ronaldvdmeer wants to merge 0 commit intolmaertin:mainfrom
Closed
Convert enabled/disabled sensors to binary_sensor type#28ronaldvdmeer wants to merge 0 commit intolmaertin:mainfrom
ronaldvdmeer wants to merge 0 commit intolmaertin:mainfrom
Conversation
Contributor
Author
|
#27 failed on the tests.. This is the new PR with the fix in test script |
d2e844f to
abfc5e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert
circulation_pump_status,power_on_delay_status, andflow_delay_statusfrom sensor type with string conversion (disabled/enabled) to binary_sensor type with boolean conversion (false/true).This aligns with Home Assistant's entity model where on/off states should be represented as binary sensors rather than enum sensors.
Changes
model_PDPR1H1HAW100_FW539187.json: Changed type fromsensortobinary_sensorand conversion values from"disabled"/"enabled"tofalse/truefor:circulation_pump_statuspower_on_delay_statusflow_delay_statustest_mapping_info.py: Updated entity type counts (sensor 22→19, binary_sensor 20→23) and moved the 3 entities from sensor to binary_sensor test assertionsCLI output for cross-check