Add IDs Passmethod #76
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandohds564
requested review from
Gabrielrezende-asc,
VitorSouzaLNLS,
murilobalves,
otavio-silveira,
vellosok75 and
xresende
…instead of the filename.
… its attributes rather than a filename.
- Now the variable kicktable_list is a static variable of the Kicktable class - the methods to add_kicktable and new Kicktable constructors were added to not necessarily depend on a filename. They are also static methods of the Kicktable class; - methods were added to check if a given Kicktable is valid and if a given index for the kicktable_list is valid
xresende
reviewed
Aug 23, 2024
…n package. basic functions were tested.
…to end of name to ensure values are not glued to them.
…cktable_list to fix broken references.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
This PR adds a new pass method to IDs, based on the kickmap approach, but substituting the two table interpolation with two 2D polynoms on variables x and y. This has the advantage of not having the derivative discontinuities generated by the linear interpolation of table. On the other hand, it may suffer from difficulties on fitting the kickmaps with simple, low order polynoms.