Provide fresh DetachedCaptures for each nested fragment #299
Open
Endilll wants to merge 3 commits intolock3:cppxfrom
Open
Provide fresh DetachedCaptures for each nested fragment #299Endilll wants to merge 3 commits intolock3:cppxfrom
Endilll wants to merge 3 commits intolock3:cppxfrom
Conversation
like CXXFragmentParseRAII does with PendingUnquotes
|
@DarkArc Friendly ping 🤣 |
Author
|
Looking back, this looks decent for my very first dive into Clang codebase. |
Contributor
|
I don't see any issues with the change; but it likely won't be merged because Lock3 has not been operating to my knowledge for some time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...like
CXXFragmentParseRAIIdoes withPendingUnquotes.Otherwise nested fragments with captures fail at meta/clang/lib/Sema/SemaInject.cpp:2762:
void clang::Sema::attachCaptures(clang::CXXFragmentExpr *): Assertion 'E->getNumCaptures() == DetachedCaptures.size()' failed.While this PR helps with nested fragments in this particular test, more complicated ones would still fail.