Skip to content

Conversation

@simeng-li
Copy link
Contributor

Summary

  • Bump Expo SDK support in @logto/rn to include SDK 54~.
  • Update the rn-sample using Expo SDK 54 with matching dependencies.
  • Widen @logto/rn SDK peer dependency ranges to cover Expo SDK 52~ and 54~ while pinning dev deps accordingly.

Testing

test locally on ios simulator

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

update async-storage dep version cap
@simeng-li simeng-li requested review from Copilot and gao-sun January 28, 2026 08:13
@simeng-li simeng-li changed the title refactor(rn): bump expo SDK to 54 refactor(rn): bump expo SDK to 54 Jan 28, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the React Native (Expo) SDK and sample app to support Expo SDK 54 while broadening @logto/rn compatibility across Expo SDK 52–54.

Changes:

  • Bumped @logto/rn version and widened peer dependency range for async storage.
  • Updated rn-sample dependencies to Expo SDK 54 / React 19 / RN 0.81.
  • Adjusted Expo app config and removed the custom Metro config from the sample.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
packages/rn/package.json Bumps package version, updates dev deps (RN/Expo modules), and broadens peer dependency range for async-storage.
packages/rn-sample/package.json Moves the sample app to Expo SDK 54 + updated React/RN ecosystem versions.
packages/rn-sample/metro.config.js Removes the monorepo Metro override in favor of default Expo/Metro behavior.
packages/rn-sample/app.json Adds Expo plugins and reformats config values for SDK 54 setup.
Comments suppressed due to low confidence (1)

packages/rn/package.json:67

  • @logto/rn imports from react (hooks/components) but doesn’t declare react in peerDependencies. Declaring an explicit react peer range (aligned with the supported Expo SDKs / React versions) makes the package’s runtime requirement clear and helps package managers validate consumer installs.
    "@react-native-async-storage/async-storage": ">=1.23.1 <3",
    "expo-crypto": ">=14.0.2 <16",
    "expo-secure-store": ">=14.0.1 <16",
    "expo-web-browser": ">=14.0.2 <16",
    "react-native": ">=0.76.0 <1"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@simeng-li simeng-li requested review from a team and charIeszhao and removed request for a team January 29, 2026 06:09
@simeng-li simeng-li merged commit 4517941 into master Jan 29, 2026
8 of 9 checks passed
@simeng-li simeng-li deleted the simeng-bump-rn-sample-expo-version branch January 29, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants