Modernize henry - fixes all current bugs and switches to non-deprecated system__activity#85
Merged
josephaxisa merged 4 commits intolooker-open-source:masterfrom Apr 20, 2024
Merged
Conversation
Contributor
|
Can you confirm that you've verified this fixes the issue? Also can you link the issue in the PR description? |
Collaborator
Author
This resolves the issue (see first output of 
|
|
Please merge this update. It resolves one of the issues at least. |
…ndpoint in get_used_models()
This was referenced Apr 12, 2024
rbob86
changed the title
rbob86
changed the title
josephaxisa
approved these changes
Apr 20, 2024
Collaborator
josephaxisa
left a comment
josephaxisa
left a comment
There was a problem hiding this comment.
all changes look reasonable, thanks for the PR @rbob86
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash due to outdated object reference
#82
Fixes crash due to invalid field reference in call to run_inline_query in get_used_models()
#86
Fixes invalid filter error due to i__looker losing workspace_id filter
#83
Adds
looker__internal_analytics__replicato reserved_names in check_db_connectionIncorporates changes from #57 to use system__activity instead of i__looker, which is deprecated.