feat: generate SDKs for Looker 26.0 #1631
Conversation
Release-As: 26.0.0
Summary of ChangesHello @drstrangelooker, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on generating the SDKs for Looker version 26.0. It incorporates new API methods for managing OAuth applications and service accounts, introduces additional parameters for content searching, and expands existing data models with new properties. The changes also include significant updates to documentation, clarifying feature availability and the impact of certain operations. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the SDKs for Looker 26.0, including version bumps, new API methods and models, and documentation improvements. The changes are mostly auto-generated and look good across the different languages. I've pointed out some formatting inconsistencies in the C# SDK that should be addressed for better code style and maintainability.
| public async Task<SdkResponse<string, Exception>> delete_external_oauth_application( | ||
| string client_id, | ||
| ITransportSettings? options = null) | ||
| { | ||
| client_id = SdkUtils.EncodeParam(client_id); | ||
| return await AuthRequest<string, Exception>(HttpMethod.Delete, $"/external_oauth_applications/{client_id}", null,null,options); | ||
| } |
There was a problem hiding this comment.
The formatting of this method is inconsistent with the rest of the file. Let's adjust the bracing and indentation to follow standard C# conventions and match the surrounding code style for better readability and maintainability.
public async Task<SdkResponse<string, Exception>> delete_external_oauth_application(
string client_id,
ITransportSettings? options = null)
{
client_id = SdkUtils.EncodeParam(client_id);
return await AuthRequest<string, Exception>(HttpMethod.Delete, $"/external_oauth_applications/{client_id}", null, null, options);
}| public async Task<SdkResponse<ServiceAccount, Exception>> update_service_account( | ||
| string user_id, | ||
| WriteServiceAccount body, | ||
| string? fields = null, | ||
| ITransportSettings? options = null) | ||
| { | ||
| user_id = SdkUtils.EncodeParam(user_id); | ||
| return await AuthRequest<ServiceAccount, Exception>(HttpMethod.Patch, $"/users/service_accounts/{user_id}", new Values { | ||
| { "fields", fields }},body,options); | ||
| } |
There was a problem hiding this comment.
The formatting of this method is inconsistent with the rest of the file. Let's adjust the bracing, indentation, and the AuthRequest call to follow standard C# conventions and match the surrounding code style for better readability and maintainability.
public async Task<SdkResponse<ServiceAccount, Exception>> update_service_account(
string user_id,
WriteServiceAccount body,
string? fields = null,
ITransportSettings? options = null)
{
user_id = SdkUtils.EncodeParam(user_id);
return await AuthRequest<ServiceAccount, Exception>(HttpMethod.Patch, $"/users/service_accounts/{user_id}", new Values { { "fields", fields } }, body, options);
}| public async Task<SdkResponse<string, Exception>> delete_service_account( | ||
| string user_id, | ||
| ITransportSettings? options = null) | ||
| { | ||
| user_id = SdkUtils.EncodeParam(user_id); | ||
| return await AuthRequest<string, Exception>(HttpMethod.Delete, $"/users/service_accounts/{user_id}", null,null,options); | ||
| } |
There was a problem hiding this comment.
The formatting of this method is inconsistent with the rest of the file. Let's adjust the bracing and indentation to follow standard C# conventions and match the surrounding code style for better readability and maintainability.
public async Task<SdkResponse<string, Exception>> delete_service_account(
string user_id,
ITransportSettings? options = null)
{
user_id = SdkUtils.EncodeParam(user_id);
return await AuthRequest<string, Exception>(HttpMethod.Delete, $"/users/service_accounts/{user_id}", null, null, options);
}
Python Tests 9 files 9 suites 1m 9s ⏱️ Results for commit 764c827. ♻️ This comment has been updated with latest results. |
Typescript Tests 2 files 56 suites 1m 0s ⏱️ Results for commit 764c827. ♻️ This comment has been updated with latest results. |
2 participants
Release-As: 26.0.0