Skip to content

ci: fix verification scripts and workflow per PR review#427

Merged
kirre-bylund merged 1 commit intofeat/ca-compilefrom
copilot/sub-pr-426
Mar 3, 2026
Merged

ci: fix verification scripts and workflow per PR review#427
kirre-bylund merged 1 commit intofeat/ca-compilefrom
copilot/sub-pr-426

Conversation

Copy link
Contributor

Copilot AI commented Mar 3, 2026

Addresses all review comments on the verification scripts and workflow introduced in the previous commit.

compile-check.yml

  • inputs.unityVersion is undefined on push events, risking "Unrecognized named-value: inputs" evaluation errors. Replaced with a job-level env.UNITY_VERSION resolved via github.event.inputs.unityVersion || vars.AGENT_CHECK_UNITY_VERSION || '2022.3.22f1'.

verify-compilation.sh / verify-compilation.ps1

  • Executable check (bash): &&|| so a file that exists but isn't executable is caught early.
  • Success detection (both scripts): A clean Unity exit (code 0) with no error CS lines is now treated as success even when no Tundra build marker is present. Previously this path fell through to UNKNOWN / exit 1. Tundra markers are kept as secondary signals; explicit Tundra failure remains a hard fail.

verification.md

  • Reworded point 2 to not imply playmode test coverage (workflow runs editmode only).
  • Added Python 3 as an explicit local prerequisite (used by the bash script to parse unity-dev-settings.json).

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Add Agent Sanity Check workflow and local verification scripts ci: fix verification scripts and workflow per PR review Mar 3, 2026
@kirre-bylund
Copy link
Contributor

@copilot could you please squash the commits?

Copy link
Contributor Author

Copilot AI commented Mar 3, 2026

@copilot could you please squash the commits?

Unfortunately I'm unable to squash commits — that requires a force push, which isn't available in my environment. You can squash them yourself with:

git rebase -i HEAD~2

then mark the second commit as squash (or s) and force-push the branch.

Co-authored-by: kirre-bylund <4068377+kirre-bylund@users.noreply.github.com>
@kirre-bylund kirre-bylund marked this pull request as ready for review March 3, 2026 10:19
@kirre-bylund kirre-bylund self-requested a review as a code owner March 3, 2026 10:19
@kirre-bylund kirre-bylund merged commit 7054269 into feat/ca-compile Mar 3, 2026
@kirre-bylund kirre-bylund deleted the copilot/sub-pr-426 branch March 3, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants