Conversation
… on active contest instances with incomplete assigned rounds. This change improves data retrieval efficiency and ensures judges only see relevant assignments, enhancing the user experience in contest management.
…e and creating round judge assignments. This update ensures tests accurately reflect the current business logic, improving test coverage and maintaining data integrity in contest management.
…ontest instances and completed judging rounds. This update improves test coverage by ensuring judges do not see contests that are inactive or have completed rounds, aligning tests with current business logic in contest management.
… unassigned judges. Changed test expectations to display 'You have not been assigned to judge any contests.' instead of 'No active rounds assigned to you', improving clarity and alignment with user experience in contest management.
Fix_judges_display_of_contests
- Introduced ContestActivationController to manage contest activation logic. - Updated contest description and instance forms to integrate the new controller, enabling confirmation prompts for inactive contests. - Enhanced error handling in ContestDescriptionsController to render appropriate templates based on action type. - Improved user experience by ensuring relevant data attributes are set for dynamic interactions.
- Introduced tests for ContestDescriptionsController, covering new and create actions, including validation and Turbo Stream responses. - Added specs for ContestInstancesController, focusing on creation and update actions, ensuring proper handling of active status and associations. - Implemented JavaScript tests for ContestActivationController, validating confirmation dialog behavior and form submission logic. - Enhanced system tests for contest activation workflows, ensuring user interactions align with expected outcomes for both contest descriptions and instances.
- Updated ContestActivationController to prevent default form submission temporarily and show a confirmation dialog for activating contests. - Implemented form submission using requestSubmit for better validation handling, with a fallback for older browsers. - Improved user experience by ensuring proper form submission flow based on user confirmation.
- Modified contest description factory to create active instances for testing. - Enhanced contest instance creation specs to include category and class level associations. - Improved system tests for contest activation workflow, ensuring proper handling of active checkbox and form submission logic. - Updated JavaScript interactions to bypass confirmation dialogs for more streamlined testing.
…k-to-confirm-a-user-is-creating-a-contest-instance-or-a-contest-description-and-it-is-not-set-to-active LRA-1041-lsa-evaluate-add-a-check-to-confirm-a-user-is-creating-a-contest-instance-or-a-contest-description-and-it-is-not-set-to-active
- Introduced a polyfill for requestSubmit on HTMLFormElement to ensure compatibility with JSDOM. - This enhancement allows for better form submission handling in tests, improving overall test reliability.
…on handling - Updated tests to utilize a polyfill for requestSubmit, ensuring compatibility with JSDOM. - Enhanced form submission logic in tests by replacing direct event dispatching with click events for better simulation of user interactions. - Improved handling of custom confirmation messages and ensured proper verification of form submission outcomes. - Added cleanup steps to restore original methods after tests, enhancing test reliability and maintainability.
- Updated tests to verify that all rankings for an entry are correctly updated when selected or deselected for the next round. - Improved the verification process by checking the database state after interactions, ensuring accurate reflection of user actions. - Implemented retry logic to handle asynchronous updates in the database, enhancing test reliability and accuracy.
- Modified the EntryRankingsController to update the `selected_for_next_round` status for all rankings associated with an entry in the current judging round. - Enhanced logging to provide better insights into the number of updated rankings and their corresponding entry IDs. - Updated view rendering to ensure correct entry and judging round references are used in Turbo Stream responses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.