Skip to content

Add send_instructions? method to ContestInstancePolicy and update specs #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rsmoke merged 1 commit into from
Sep 10, 2025
Merged

Add send_instructions? method to ContestInstancePolicy and update specs #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/policies/contest_instance_policy.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,4 +88,8 @@ def send_round_results?
def export_entries?
user&.has_container_role?(record.contest_description.container) || axis_mundi?
end

def send_instructions?
user&.has_container_role?(record.contest_description.container) || axis_mundi?
end
end
5 changes: 5 additions & 0 deletions spec/policies/contest_instance_policy_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
it { is_expected.to permit_action(:update) }
it { is_expected.to permit_action(:destroy) }
it { is_expected.to permit_action(:manage_judges) }
it { is_expected.to permit_action(:send_instructions) }

describe 'view_judging_results?' do
it 'permits viewing results' do
Expand All @@ -43,6 +44,7 @@
it { is_expected.to permit_action(:update) }
it { is_expected.to permit_action(:destroy) }
it { is_expected.to permit_action(:manage_judges) }
it { is_expected.to permit_action(:send_instructions) }

describe 'view_judging_results?' do
it 'permits viewing results' do
Expand All @@ -64,6 +66,7 @@
it { is_expected.not_to permit_action(:update) }
it { is_expected.not_to permit_action(:destroy) }
it { is_expected.not_to permit_action(:manage_judges) }
it { is_expected.not_to permit_action(:send_instructions) }

describe 'view_judging_results?' do
context 'when judge evaluations are complete' do
Expand Down Expand Up @@ -97,6 +100,7 @@
it { is_expected.not_to permit_action(:update) }
it { is_expected.not_to permit_action(:destroy) }
it { is_expected.not_to permit_action(:manage_judges) }
it { is_expected.not_to permit_action(:send_instructions) }

describe 'view_judging_results?' do
it 'does not permit viewing results' do
Expand All @@ -114,6 +118,7 @@
it { is_expected.not_to permit_action(:update) }
it { is_expected.not_to permit_action(:destroy) }
it { is_expected.not_to permit_action(:manage_judges) }
it { is_expected.not_to permit_action(:send_instructions) }

describe 'view_judging_results?' do
it 'does not permit viewing results' do
Expand Down