Merged
Conversation
Fix tests to force internal coloring independently of `NO_COLOR` in the calling environment, to ensure that they pass. This is needed when `NO_COLOR` is set globally in the environment, e.g. when collecting plain text test logs. Technically, `crossterm::style::force_color_output()` leaks to other tests. However, there should be no harm in setting it globally, and the library does not seem to provide a trivial way to scope the change. Just call it in both places where it is actually necessary, to ensure that things work correctly also when only parts of the test suite are run. Fixes lsd-rs#1136 Signed-off-by: Michał Górny <mgorny@gentoo.org>
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix tests to force internal coloring independently of
NO_COLORin the calling environment, to ensure that they pass. This is needed whenNO_COLORis set globally in the environment, e.g. when collecting plain text test logs.Technically,
crossterm::style::force_color_output()leaks to other tests. However, there should be no harm in setting it globally, and the library does not seem to provide a trivial way to scope the change. Just call it in both places where it is actually necessary, to ensure that things work correctly also when only parts of the test suite are run.Fixes #1136
TODO
cargo fmt