bug: Handle function name duplicates when using TAP#20
Merged
lsiddiquee merged 4 commits intomainfrom Jul 8, 2025
Merged
Conversation
…ugins. This is needed to support additional filtering that was introduced for TAP duplicate methods and also open generics.
…mple using CLR random.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where function name duplicates were not handled when using the Task-based Asynchronous Pattern (TAP) in CLR type plugins. This happens in two specific scenarios:
The plugin builder now filters out these duplicates by normalizing the functions by removing the cancellation token parameter and async suffix then choosing the one with the CancellationToken parameter if available or the one with async suffix in the order.
Also sample have been updated to use Random, which showcases how to handle function overload and azure queue client sdk where the tap function name duplicate happens.
Closes #16