feat(runtime): add setup option for agnostic runtime support#85
Draft
jgero wants to merge 1 commit intolspcontainers:mainfrom
Draft
feat(runtime): add setup option for agnostic runtime support#85jgero wants to merge 1 commit intolspcontainers:mainfrom
jgero wants to merge 1 commit intolspcontainers:mainfrom
Conversation
Contributor
Author
|
Should the networking mode be also contained as an setup variable? When we then create the docker/podman command the Setup would then look something like:
And LSP config: |
By moving the runtime to a config option which is set during setup the runtime parameter is not necessary anymore for each LSP `cmd`. Also rename the global configuration variable to something plugin related to make it obvious which plugin is responsible for that variable and to avoid possible name collisions.
Contributor
|
To be included in #92 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By moving the runtime to a config option which is set during setup the
runtime parameter is not necessary anymore for each LSP
cmd.Closes #84
Also rename the global configuration variable to something plugin
related to make it obvious which plugin is responsible for that variable
and to avoid possible name collisions.