DM-50896: Fix click duplicate option warnings#355
Conversation
click now warns if an option is declared twice.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #355 +/- ##
==========================================
+ Coverage 85.91% 85.95% +0.04%
==========================================
Files 44 44
Lines 2534 2542 +8
Branches 260 264 +4
==========================================
+ Hits 2177 2185 +8
Misses 256 256
Partials 101 101 ☔ View full report in Codecov by Sentry. |
MichelleGower
left a comment
There was a problem hiding this comment.
Merge approved. I couldn't reproduce the problem with --help on the various subcommands like I can with current weekly. I also double checked that it doesn't happen with ctrl_bps in weekly.
I do find it a little confusing that pipeline_build_options does have a butler_config to skip but qgraph_options does not and line 216 explicitly calls butler_options. I think this is because with pipeline build the repo is optional (and it still works in a manual test). I don't have any suggestions on how to make it better though.
These warnings were added in click by pallets/click#2397
Checklist
doc/changes