Draft
Conversation
RobertLuptonTheGood
force-pushed
the
tickets/DM-19256
branch
2 times, most recently
from
2a52fca to
2c510c8
Compare
RobertLuptonTheGood
force-pushed
the
tickets/DM-19256
branch
from
2c510c8 to
7cedd52
Compare
Member
|
Who do we need to look into this? I think this might need some work to bring up to date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the work that I did for Aaron in response to some queries about the original code. As you'll see from the commit message it's not really ready to be merged, but more importantly I'm waiting for someone from the camera to confirm that this resolves their problems,