DM-53043: Add R_lam extinction coeffs for LSSTCam#676
Open
Conversation
yalsayyad
force-pushed
the
tickets/DM-53043
branch
from
0566a5f to
2534461
Compare
from rubin_sim.phot_utils.
yalsayyad
force-pushed
the
tickets/DM-53043
branch
from
2534461 to
93c8b90
Compare
laurenam
approved these changes
Nov 12, 2025
Contributor
laurenam
left a comment
laurenam
left a comment
There was a problem hiding this comment.
Can you fix the commit title/message?
| @@ -0,0 +1,18 @@ | |||
| # Extinction coefficients (R_filter) for LSSTCam filters for conversion | |||
| # from E(B-V) to extinction: A_filter = E(B-V) * R_filter | |||
| # Band, R_filter | |||
Contributor
There was a problem hiding this comment.
What information is this third line trying to convey?
| # Band, R_filter | ||
|
|
||
| # These default extinction coefficients are not optimal for the FGCM standard | ||
| # bandpasses. |
| # bandpasses. | ||
| # From rubin_sim.phot_utils, DustValues().r_x provides the | ||
| # values for the Rubin filters. These values are calculated using the CCM89 | ||
| # extinction curve (Cardelli, Clayton, and Mathis 1989), assuming a flat |
| "i": 2.053659, | ||
| "z": 1.59009, | ||
| "y": 1.3077049, | ||
| } |
Contributor
There was a problem hiding this comment.
Why don’t they all get the same number of sig figs?
| # These default extinction coefficients are not optimal for the FGCM standard | ||
| # bandpasses. | ||
| # From rubin_sim.phot_utils, DustValues().r_x provides the | ||
| # values for the Rubin filters. These values are calculated using the CCM89 |
Contributor
There was a problem hiding this comment.
The “as delivered” filters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from rubin_sim.phot_utils.