DM-50999: Reorganize to support EUPS-less usage#697
Conversation
40d72ac to
ba2a590
Compare
2a774d7 to
c8110af
Compare
| with ResourcePath( | ||
| "resource://lsst.obs.lsst/resources/policy/latiss.yaml", forceDirectory=False | ||
| ).as_local() as policy_file: | ||
| camera = yamlCamera.makeCamera(policy_file.ospath) |
There was a problem hiding this comment.
It would be pretty easy to change makeCamera and IsrCalib.readtext to work with ResourcePath. Maybe I should do that.
d51b10d to
0e4cdb2
Compare
0e4cdb2 to
f4a6831
Compare
erykoff
left a comment
There was a problem hiding this comment.
I think this is fine but I am still not sure why some places are eups: and some are resource:.
Also, have the config loads always been relative and somewhere along the way we cargo culted full paths?
|
Configs did not work with relative paths until lsst/pex_config#131 where the code was "fixed" to make it work properly (otherwise it would try to load relative to cwd). Hence all the |
This is already where there existed other data files so it's better to put them in a single place with the tests. This did require that each test file declares where the test directory is but that doesn't seem completely unreasonable.
…s tree Retain original locations for now. policy can not be moved because of scons but the camera files are copied into the python resources tree. Once things stabilize we can move the primary location of config and corrections inside the python tree and reverse the symlinks. Keep the original locations to minimize diffs and chances of conflicts during prototyping when DP2 is being actively worked on.
f4a6831 to
30fe0e1
Compare
|
The
|
|
@erykoff I think at one point you asked about readText supporting ResourcePath. I think that is something we can ticket but there are lots of IsrCalib classes that would need to be modified to support it and they all have to be converted at once before it can be used. |
30fe0e1 to
8986421
Compare
Requires lsst/obs_base#543 and lsst/obs_lsst_data#32