DM-54255: No longer fail calculating tracking_radec if DATE-OBS is missing#707
Merged
DM-54255: No longer fail calculating tracking_radec if DATE-OBS is missing#707
Conversation
This happens for visits if not raws.
kherner
approved these changes
Feb 26, 2026
kherner
left a comment
There was a problem hiding this comment.
My only comment is whether lsst.py is the only place where this change needs to be made. The file for LATISS does similar things with DATE-OBS, for example.
Member
Author
|
The latiss translator inherits from the lsst base translator. The DATE-OBS mentions for latiss are for fixing headers and are protected by an existence check so I think it's okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens for visits if not raws.