Implement RFC type:issubtypeof#2133
Open
PhoenixWhitefire wants to merge 14 commits intoluau-lang:masterfrom
Open
Implement RFC type:issubtypeof#2133PhoenixWhitefire wants to merge 14 commits intoluau-lang:masterfrom
type:issubtypeof#2133PhoenixWhitefire wants to merge 14 commits intoluau-lang:masterfrom
Conversation
Additionally, adds a new test, as well as the flags `LuauTypeDefinitionsTypeIsSubtypeOf` and `LuauTypeFunctionTypeIsSubtypeOf`
vegorov-rbx
reviewed
Dec 8, 2025
Member
|
This needs to be rebased. |
Contributor
Author
|
Merged |
aatxe
reviewed
Feb 4, 2026
|
|
||
| // TODO: split into separate tagged unions when the new solver can appropriately handle that. | ||
| static constexpr const char* kBuiltinDefinitionTypeMethodSrc = R"BUILTIN_SRC( | ||
| // With both `extern` replacing `class`, and `:issubtypeof` |
Member
There was a problem hiding this comment.
I think we can probably clean up the class replacement soon, might just wait for that to avoid this mess.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, adds a new test, as well as the flags
LuauTypeDefinitionsTypeIsSubtypeOfandLuauTypeFunctionTypeIsSubtypeOf.https://rfcs.luau.org/method-type-issubtypeof.html
luau-lang/rfcs#101