Implement read-only/write-only table indexer syntax#2137
Draft
PhoenixWhitefire wants to merge 14 commits intoluau-lang:masterfrom
Draft
Implement read-only/write-only table indexer syntax#2137PhoenixWhitefire wants to merge 14 commits intoluau-lang:masterfrom
PhoenixWhitefire wants to merge 14 commits intoluau-lang:masterfrom
Conversation
…teOnlyIndexers` flag
Contributor
Author
|
Not finished yet: --!strict
function _foo(x: { read number })
local y: { number } = x
y[1] = 5 -- No Type Error
endEDIT: Fixed, and improved error messages |
I need to fix this bug in 2 different PRs, so I'm flagging it with a non-PR-specific name
Re-add flags I accidentally deleted in the merge
Contributor
Author
|
index? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Additionally adds the
LuauReadWriteOnlyIndexersandLuauLValueCompoundAssignmentVisitLhsflag and 6 new testsThe tests are casting string indexing to
:: stringexplicitly because there seems to be an unrelated bug where string singletons are not checked properlyDefined in RFC https://rfcs.luau.org/syntax-property-access-modifiers.html, https://rfcs.luau.org/property-writeonly.html, https://rfcs.luau.org/property-readonly.html
The
LuauLValueCompoundAssignmentVisitLhswas added to prevent a merge conflict with #2071, which implements the same fix.