Fix false LocalShadow warning triggered by type function references#2240
Open
adityuhkapoor wants to merge 1 commit intoluau-lang:masterfrom
Open
Fix false LocalShadow warning triggered by type function references#2240adityuhkapoor wants to merge 1 commit intoluau-lang:masterfrom
adityuhkapoor wants to merge 1 commit intoluau-lang:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2087
The LocalShadow lint walker traverses into AstStatTypeFunction bodies, where type references like num appear as AstExprGlobal nodes. When a local variable with the same name is declared later, the linter incorrectly reports a shadow warning.
This skips traversal into AstStatTypeFunction nodes in LintLocalHygiene, matching how the compiler's FunctionVisitor already handles them.