Open
Conversation
…ng mandolin configs
Collaborator
|
Can you not just use |
Collaborator
|
Nevermind, looks like Microsoft only allows variables for certain privileged settings. I think we should still have users specify relative paths by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for providing Mandolin configuration values (i.e
foremanTomlPath,rulesPath, etc) as relative paths instead of absolute. This is a nice QoL feature that makes configuring Mandolin per-workspace easier and importantly, allows us to commit Mandolin settings to a repo once, for example, and have them work and apply to all users of that repo thereafter.Paths are resolved relative to the workspace root of the open file when Mandolin runs.